...unless it's a signature part of that guitar sound....like with surf or rockabilly. Gotta have fat reverb for that, preferably spring....
Yes...and that's the thing. There are few situations where reverb IS a signature part of the tone, like the ones you mentioned.
I like the idea of using the amp's reverb if it's an integral part of the guitar tone. Adding it in post seems to be the best choice if it's meant to add texture or depth.
I mean...any time you play guitar, no matter what style, if you turn on the reverb, to you it will become part of the tone, but that's not the same as it being a signature element of the tone.
I always like to hear some reverb when I'm cutting guitar leads...but...it's not really a part of the guitar tone, 9-out of 10 times it's just adding some space and depth, and for that, you want to leave it for the mix session because all your other elements are also going to have to fit into a certain space...which is why it can be risky recording it with the guitar track, 'cuz you are stuck with it.
There's a reason theyh now have some "de-verb" plugins...'cuz too many times great tracks were recorded, and then people went,
"shit, the reverb is all wrong, but now I can't get rid of it, so I have to re-track".
Not to mention, when you're just focusing on the guitar track, there will be a tendency to have more reverb mixed in. Same thing happens when tracking a lead vocal, it just sound better with a bit more reverb....but then in the mix, you want a lot less.
So like I said earlier, I make sure my cue mixes have all the reverb I want...it's all safe, since it's only part of the cue mix, but it gives me that space and depth I like to hear.
Then when I mix, I can make a better decision about reverb...and generally, I always end up using much less than what I liked in the cue mixes during tracking.
All that said...I never sweat it anyway. There's never been a track that I didn't mind re-tracking if I had to.
It's more of a concern when you are working with clients...and having to tell Joe Shred that his Arena Rock lead has to be done over 'cuz the reverb he had going on from the amp is mushing up the mix!
When you are working on your own stuff...do whatever you feel like. If you don't like it...do it over.