This is my most unlistenable song. It is painful at even low volumes. I've given at least one person a mild stroke with this piece.
And there, Jordan, lies the difference. Every songwriter has written some really bad songs, myself included. The key is to recognize when something is really bad and shelve it quickly. Any audience that might be interested in hearing your music is going to be quickly diminished if you start forcing bad music down their ear canals.
This notion that some sizable audience is going to be interested because you've "laid your soul out," is platitudinal nonsense. Have anyone make a list of their favorite songs and you're going to find that the majority of them are favorites because the listener can relate the song to their own lives in some way. Sure, some songs will make the list because the melody is striking or there's something admirable in the performance or the song was playing at some significant time, but most will be there because the listener makes some connection between the song and their own lives.
Another important aspect of songwriting is to look at your lyrics with a critical eye. Sometimes, we're so impressed with something we write that we fail to see the contradictions we've created. I'll use your song, "Gold Queen," as an example since someone conveniently posted the lyrics for me.
the golden queen was in the place
a blade of grass against the suns rays
the queen will speak her dreams
clouds will come to the sea
have a parade
boys on the stage
drink lemonade
wings on a snake
the ruling world will crash to the ground
people die wont be making a sound
who can save our dreams
i depend on the queen
have a parade
play on the stage
creating our games
love the snake
You say "the ruling world will crash to the ground," but then three lines later you say. "I depend on the queen." Wouldn't a queen be part of a ruling class? It certainly sounds conflicted. Of course, it could just be poor choices of metaphor...
For example, you introduce the queen with a grass metaphor that's ambiguous. I don't know if calling her "a blade of grass against the sun's rays" is positive or negative. I don't know what it's supposed to represent because you leave the metaphor behind as quickly as you introduce it. Your metaphors lack the details that give a listener insight into what you're trying to say. In truth, the lyrics to that song read like a string of unconnected, undeveloped metaphors. There's no theme; there's no sensible construct.
If you're going to use metaphors, try not to jump around so much. Connect the metaphors together in some way that brings cohesion and understanding. I'll use one of my own songs as an example:
Show Me a Path
Chorus:
Make me a hole, show me a path
Give me a place to start
I’ll walk this maze through the hurt that has passed
And somehow I’ll find your heart
I’ve got a compass, a map, and desire
And moonlight enough to see
I’ve got one bright star to guide me
Through the thicket, through the trees
I’ve got boots, good for walking
On this ground softened by tears
This wood has known some heartache
And my heart has known some fear
Chorus
Sometimes the road lay hidden
The undergrowth fools my eyes
Getting darker as I go deeper
But I have to believe this is right
And if it’s right my faith will guide me
And my hope will calm my fear
And my love will push me onward
Until I find you near
Bridge:
And when the light comes through the trees
And the man in the moon, he smiles
He knows no one can rescue me
Not after all these miles
Someday there’ll be time for reflecting
But not while there’s road ahead
If I rest right here that star might disappear
So I push on instead
Chorus
Although it may seem like there are more, the song really only has two metaphors: the forest and the moon. All the other things ...the maze, the light, the soft ground, etc... all are part of the forest metaphor, therefore connected.
Songwriting is a craft. It's no different than learning to paint, to sculpt, to design houses, etc. It's something that needs to be developed over time. Mistakes will be made and must be made and recognized if the artist is going to progress and become better at it.
I'll end this with an appropriate metaphor: just because a painter has 50 tubes of color in his box, it doesn't mean he should be using 50 colors in every painting.