Are modules going away?
The short answer: YES; well sort of...
However if you're looking for rackmount hardware modules, you can pick them up for fairly cheap these days, but I have another option for you: The Receptor from Muse Research.
If you are not familiar with these they are essentially a purpose built 2U rack mount designed for use with plug-ins and virtual instruments. You can load all of your softsynths and processors into it's internal hard drive (mines 450GB but I'm thinking of going with a TB drive soon).
In the recording environment, it takes all of the burden off of your computer, and being that it is not your computer, it's not worried about emails, greeting card editors and all that extra junk.
It also has a guitar/instrument input so you can plug your guitar into it, and use
Amplitube, or Revalver, or whatever for your guitar sound, and go straight to the PA, or your usual amp rig if you wanted to use it as just a preamp and skip the cabinet simulators. So synth module, guitar amp sim and processor, E-Drum module, guitarsynth, its up to you.
They are pricey, but well worth it. They did do one in conjunction with Peavey, but it's fairly limited by comparison.
LINK:
Muse Research support - Receptor videos and tutorials